Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jun 5, 2025

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist
Copy link
Member Author

ping @hoheinzollern

@affeldt-aist
Copy link
Member Author

@hoheinzollern changelog and doc are complete (hopefully)

@affeldt-aist
Copy link
Member Author

ping @hoheinzollern

Copy link
Member

@hoheinzollern hoheinzollern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've yet to check the changelog, but please consider the comments below,

@affeldt-aist
Copy link
Member Author

Many thanks for the review. Most comments answered. Note that if this gets merged, it will be checked once again because the prob_lang PR (#1712) depends on it. It will therefore be rebased and this will be the occasion to detect more issues if any.

@affeldt-aist affeldt-aist force-pushed the probability_20250605 branch 2 times, most recently from b97756a to 8443595 Compare November 1, 2025 00:00
@affeldt-aist
Copy link
Member Author

(rebased on top of master, changelog does not seem broken)

@affeldt-aist
Copy link
Member Author

@hoheinzollern CI green

@affeldt-aist affeldt-aist added this to the 1.14.0 milestone Nov 6, 2025
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Nov 6, 2025
@affeldt-aist
Copy link
Member Author

(the last commit is actually fixing a problem in master...)

@affeldt-aist affeldt-aist merged commit e116406 into math-comp:master Nov 7, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants