Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix #1194

Merged
merged 6 commits into from
Feb 19, 2025
Merged

CI fix #1194

merged 6 commits into from
Feb 19, 2025

Conversation

esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Feb 18, 2025

Very small fix to patch CI segfaults - seems like the issue is with newer versions of the openff libraries. Pinning them to the versions we use in atomate2's CI

@esoteric-ephemera esoteric-ephemera changed the title [WIP] CI fix CI fix Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (fa089be) to head (afc7495).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1194       +/-   ##
===========================================
+ Coverage   72.19%   90.18%   +17.99%     
===========================================
  Files          77      147       +70     
  Lines        5146    14504     +9358     
===========================================
+ Hits         3715    13081     +9366     
+ Misses       1431     1423        -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esoteric-ephemera
Copy link
Collaborator Author

@tschaume: had to put a pin on the openff dependencies as well as pymatgen. For now, I think we need pymatgen<=2025.1.9 to ensure that the new bandgap parsing doesn't affect tests. Would like to address that change in a separate PR

@tschaume
Copy link
Member

Thanks for tracking this down! Can we put the pymatgen pin also into the setup.py for emmet-core? We'd want to avoid pymatgen being bumped when I run the action to upgrade dependencies next time.

@esoteric-ephemera
Copy link
Collaborator Author

Done! Good to merge?

@tschaume
Copy link
Member

Yes, looks good. Thanks!

@esoteric-ephemera esoteric-ephemera merged commit 33a0354 into materialsproject:main Feb 19, 2025
8 checks passed
@esoteric-ephemera esoteric-ephemera deleted the ci_fix branch February 19, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants