-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fix #1194
CI fix #1194
Conversation
5355e45
to
67ac51e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
===========================================
+ Coverage 72.19% 90.18% +17.99%
===========================================
Files 77 147 +70
Lines 5146 14504 +9358
===========================================
+ Hits 3715 13081 +9366
+ Misses 1431 1423 -8 ☔ View full report in Codecov by Sentry. |
@tschaume: had to put a pin on the |
c178c78
to
6018aa7
Compare
Thanks for tracking this down! Can we put the pymatgen pin also into the setup.py for |
Done! Good to merge? |
Yes, looks good. Thanks! |
Very small fix to patch CI segfaults - seems like the issue is with newer versions of the
openff
libraries. Pinning them to the versions we use inatomate2
's CI