-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Strict typing and fixed schemas for emmet document models #1174
Open
esoteric-ephemera
wants to merge
15
commits into
materialsproject:main
Choose a base branch
from
esoteric-ephemera:task_doc_refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Strict typing and fixed schemas for emmet document models #1174
esoteric-ephemera
wants to merge
15
commits into
materialsproject:main
from
esoteric-ephemera:task_doc_refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
- Coverage 72.13% 71.92% -0.21%
==========================================
Files 77 77
Lines 5149 5196 +47
==========================================
+ Hits 3714 3737 +23
- Misses 1435 1459 +24 ☔ View full report in Codecov by Sentry. |
9f28cd8
to
b7d5c54
Compare
c9b4871
to
871bf9d
Compare
… can access pymatgen attributes if lookup fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make fixed, (more-)explicitly typed document models for storing tasks / converting python objects to parquet. To do this, we have to:
Optional
) forTaskDoc
Structure
,PeriodicSite
, etc.To avoid breaking changes,
TaskDoc
is the same as before, but inherits from aDbTaskDoc
which meets the strict criteria aboveOther concurrent goals:
typing
package