✨ Add card from today notable deaths in home page #944
Conversation
WalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant PM as PunchMessage
participant DS as dateStringify
participant RC as ResultCard
participant VD as $version.data
PM->>PM: Initialize component
alt $version.data.todayDeces exists and not empty
PM->>DS: Format date from first death entry
DS-->>PM: Return formatted date string
loop For each death in todayDeces
PM->>RC: Render ResultCard with death data
end
alt deaths count != 2
PM->>PM: Insert column spacer in grid
end
else
PM-->>PM: Skip notable deaths section
end
PM->>PM: Render search link and related text
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/components/views/PunchMessage.svelte (1)
13-19:⚠️ Potential issueRemove empty anchor tag or add content.
The anchor tag has no content, making it inaccessible and non-functional. Either remove it if it's no longer needed or add appropriate content.
- <a - href="/search" - class="rf-href" - title="Recherche" - on:click|preventDefault={() => goTo({path: '/search'})} - > - </a>
🧹 Nitpick comments (3)
src/components/views/PunchMessage.svelte (3)
24-24: Simplify the conditional check.The conditional check can be simplified using optional chaining.
- {#if $version && $version.data && $version.data.todayDeces && $version.data.todayDeces.length > 0} + {#if $version?.data?.todayDeces?.length > 0}
32-34: Consider a more flexible grid layout.The current grid layout only handles a special case for 2 items. Consider using CSS Grid or Flexbox for a more responsive and flexible layout that handles any number of items gracefully.
- {#if $version.data.todayDeces.length !== 2} - <div class="rf-col-xs-0 rf-col-md-3"></div> - {/if} + <div class="rf-grid-auto">Add this to your style section:
.rf-grid-auto { display: grid; grid-template-columns: repeat(auto-fit, minmax(300px, 1fr)); gap: 1rem; width: 100%; }
81-81: Remove extra whitespace in import statement.There is unnecessary whitespace in the
dateStringifyimport.- import { dateStringify } from '../tools/masks.js'; + import { dateStringify } from '../tools/masks.js';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/views/PunchMessage.svelte(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Pull request test
🔇 Additional comments (1)
src/components/views/PunchMessage.svelte (1)
24-27: Verify data structure compatibility with backend.Please ensure that the data structure expected by the frontend (
$version.data.todayDeces) matches the response structure from the backend PR #444. Specifically, verify:
- The path to access today's deaths
- The structure of each death record used by
ResultCard- The date format expected by
dateStringifyAlso applies to: 35-37
✅ Verification successful
🌐 Web query:
What is the standard date format used by the INSEE (French National Institute of Statistics and Economic Studies) for death records?💡 Result:
The standard date format used by INSEE for death records follows YYYY-MM-DD (year-month-day) with specific handling for incomplete dates[1][2][5]. Key details include:
Date Structure
- Full dates: Expressed as
YYYY-MM-DD(e.g.,2003-04-21for Nina Simone’s death)[3][5].- Partial dates:
- Missing day/month default to
01(e.g.,1956-01-01if only the year is known)[2].- Invalid dates (e.g.,
1960-31-03) are corrected by reordering components (e.g.,1960-03-31)[2].Data Fields in Death Records
INSEE records separate components for birth and death dates:
- Birth: Day (
Jour de naissance), month (Mois de naissance), year (Année de naissance)[3].- Death: Day (
Jour de décès), month (Mois de décès), year (Année de décès)[3][5].Examples from Sources
- A corrected birth date:
1960-03-31(originally input as1960-31-03)[2].- Death record of Nina Simone:
2003-04-21[3].- FNMD entries: Dates like
1935-06-29appear in tabular data[2].This structured approach ensures consistency across France’s national mortality databases, even when handling incomplete or erroneously formatted input data[1][7].
Citations:
- 1: https://www.insee.fr/en/statistiques/4493808
- 2: https://medinform.jmir.org/2022/11/e36711/
- 3: https://en.geneanet.org/genealogyblog/post/2019/12/new-geneanet-collection-french-insee-death-index-1970-2019
- 4: https://www.insee.fr/en/information/6692672?sommaire=6692684
- 5: https://en.wikipedia.org/wiki/Fichier_des_personnes_d%C3%A9c%C3%A9d%C3%A9es
- 6: https://www.ined.fr/en/
- 7: https://www.insee.fr/en/information/2886952
- 8: https://ehp.niehs.nih.gov/doi/full/10.1289/ehp.1307771
- 9: https://www.familysearch.org/en/wiki/France,_Insee_Social_Security_Death_Index_%E2%80%93_FamilySearch_Historical_Records
- 10: https://www.ibm.com/docs/en/iodg/11.3?topic=tn-french-national-institute-statistics-economic-studies-number-masking
Integration Verified: Data Structure and Date Format
- The frontend’s access via
$version.data.todayDecescorrectly assumes an array of death records containing a nesteddeath.datefield.- The web query confirms that the INSEE standard date format is YYYY-MM-DD, which aligns with what
dateStringifyexpects.- Similar structure appears to be applied in lines 35-37.
cristianpb
force-pushed
the
feat/today-deces
branch
from
f151d3f to
3f0bb9d
Compare
To be used with matchID-project/deces-backend#444
Summary by CodeRabbit