Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Separation of concerns #19

Merged
merged 28 commits into from
Oct 11, 2019
Merged

feat: Separation of concerns #19

merged 28 commits into from
Oct 11, 2019

Commits on Sep 1, 2019

  1. Pare back code to just load the tests. 

    Currently there is only one way to load the tests; may well want to tweak this.
    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    ecf1a05 View commit details
    Browse the repository at this point in the history

  2. Remove examples dir

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    f450161 View commit details
    Browse the repository at this point in the history

  3. Remove example scripts and template README

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    5a9ee89 View commit details
    Browse the repository at this point in the history

  4. Simplify index.js to fix ESLint errors

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    1e8ab36 View commit details
    Browse the repository at this point in the history

  5. Include combined stuff when it changes, before commit

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    f2eac06 View commit details
    Browse the repository at this point in the history

  6. Rename test file for consistency

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    e283cc6 View commit details
    Browse the repository at this point in the history

  7. Return full-page tests from index.js

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    3222c67 View commit details
    Browse the repository at this point in the history

  8. Offer an option to return the HTML inline, or by file path

    @matatk
    matatk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    1644020 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2019

  1. Factor out the code that loops over all the tests

    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    09e1ac7 View commit details
    Browse the repository at this point in the history

  2. Factor out the code that gets the full-page tests

    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    785d990 View commit details
    Browse the repository at this point in the history

  3. Nicer readingtons for index.js

    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    1c9d7c6 View commit details
    Browse the repository at this point in the history

  4. Fix adding of the results of the build - we only need to add the comb… 

    …ined/ directory
    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    c53ac7e View commit details
    Browse the repository at this point in the history

  5. Trim and clarify README

    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    db49c89 View commit details
    Browse the repository at this point in the history

  6. Embed code in README 

    Found, at last, a great little package to do this; thanks, https://github.com/zakhenry/embedme :-)
    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    64f0fe7 View commit details
    Browse the repository at this point in the history

  7. Remove "json" from fenced block to stop GitHub highlighting the ellip… 

    …ses as syntax errors
    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    0f478e2 View commit details
    Browse the repository at this point in the history

  8. Add note about combined tests; remove blank line (though it does not … 

    …seem to affect rendering)
    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    064290d View commit details
    Browse the repository at this point in the history

  9. More README tweakage 

    * Fix the spacing (indentation) of the note on limitations of the
  combined tests.
* Tweak the wording and non-visible spacing around the code example.
    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    8cad4bc View commit details
    Browse the repository at this point in the history

  10. Remove redundant line in package.json

    @matatk
    matatk committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    4015275 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Clarity of purpose

    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    be37afc View commit details
    Browse the repository at this point in the history

  2. README simplification and clarification 

    * Simplify the test suite info section generally.
* Remove the first heading within "Test suite info".
* Clarify the two formats of test suite provided.
* Obfuscate example path to fixture (was Mac-specific)
    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    245a338 View commit details
    Browse the repository at this point in the history

  3. code -> setting

    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    6101611 View commit details
    Browse the repository at this point in the history

  4. setting -> secene (too many "set"s)

    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    79d40fc View commit details
    Browse the repository at this point in the history

  5. Pluralise "scene" in definition of "fixtures" 

    Finding clarity is harder than was anticipated :-).
    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    2654ddd View commit details
    Browse the repository at this point in the history

  6. Let's try to move on after this :-)

    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    2f7649a View commit details
    Browse the repository at this point in the history

  7. rly :-)

    @matatk
    matatk authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    c9a504c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Use new ESLint directive

    @matatk
    matatk committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    0b91f9a View commit details
    Browse the repository at this point in the history

  2. Bump deps' deps

    @matatk
    matatk committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    c426c1e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Remove mention of other repo for now 

    So that the PR can be merged.
    @matatk
    matatk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    23fa63d View commit details
    Browse the repository at this point in the history