Redirect back after site upload deletion #30141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the functionality of the
Admin::SiteUploadsControllerto improve user experience when deleting a site upload. Previously, upon deletion of a site upload, the user was redirected to the admin settings branding page regardless of which page you're deleting the site upload fromFor example, going to "Administration > Server settings > Appearance" and deleting an uploaded Mascot file redirects you to the "Branding" page instead of back to the "Appearance" page.
With this change, after successfully deleting a site upload, the user will now be redirected back to the page from which the deletion was initiated.