Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining pack files to Typescript #29872

Closed
wants to merge 4 commits into from

Conversation

renchap
Copy link
Sponsor Member

@renchap renchap commented Apr 7, 2024

The first commit converts all the trivial pack files. @types/webpack-env is added to have the types for require.context() and __webpack_public_path__

The second commit is automated and formats the remaining pack files using Prettier, to reduce the diff for the next commit.

The 3rd commit converts the 2 remaining packs (sign_up and two_factor_authentication).

@ClearlyClaire
Copy link
Contributor

This looks fine on principle, however I think it might be easier to review as well as easier for downstreams to handle if the first two commits were dedicated PRs.

@renchap
Copy link
Sponsor Member Author

renchap commented Apr 28, 2024

Replaced by #30102, #30105 and #30106

@renchap renchap closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants