Fix encoding with multiple encoders #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, that should be it. Not sure what causes the current error but that's out of my control, looks like it's the same error as issue #907 |
shssoichiro
force-pushed
the
multi-encoder-fix
branch
from
4e01943 to
a43141a
Compare
|
The failing test seems to have been broken in master for a while, unfortunately I haven't been able to track down what the issue is. I should probably skip those tests until we find a fix (not ideal, but it is what it is). |
shssoichiro
approved these changes
Feb 2, 2025
|
@master-of-zen Would you mind merging this? I believe you're the only one with the ability to override the CI. The failures are not related to this MR, it's the same failure from master that we haven't been able to figure out the cause of. |
Khaoklong51
pushed a commit
to Khaoklong51/Av1an
that referenced
this pull request
Mar 3, 2025
* read passes and encoder from zone overrides * run cargo fmt * remove clone calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently av1an can't use multiple encoders at the same time when specified in the zone overrides as it always passes the args from the command line when creating
chunks.json.With this fix it results in the expected behaviour, since according to the example in
av1an --helpit should be possible to do this already.I'm not that familiar with Rust so if there are things i could've done better here, please point it out.