feat(nordigen)!: add requisition hook #58
Merged
+88
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CanYumusak here it is, it's bundled with a few other overdue changes. Please let me know if it still solves your issue, i made the feature more generic in the hopes of more people finding it useful. |
Rework the requisition fulfillment to be under the Reader struct and simplify the file handling. Move the requisition hook to the Nordigen config struct and make it more generic so i can be used to handle arbitrary events tied to the requisition and its status. BREAKING CHANGE: Remove NORDIGEN_DATAFILE in favor of the YNABBER_DATADIR option. This will require recreating the requisition.
martinohansen
force-pushed
the
martin/reqs-v2
branch
from
7b5c8db
to
91161a1
Compare
CanYumusak
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the requisition fulfillment to be under the Reader struct and simplify the file handling.
Move the requisition hook to the Nordigen config struct and make it more generic so i can be used to handle arbitrary events tied to the requisition and its status.
BREAKING CHANGE: Remove NORDIGEN_DATAFILE in favor of the YNABBER_DATADIR option. This will require recreating the requisition.