Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing pixel fragments (Sourcery refactored) #234

Open
wants to merge 1 commit into
base: providing_pixel_fragments
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Aug 20, 2022

Pull Request #233 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the providing_pixel_fragments branch, then run:

git fetch origin sourcery/providing_pixel_fragments
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Aug 20, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.15%.

Quality metrics Before After Change
Complexity 4.33 ⭐ 4.35 ⭐ 0.02 👎
Method Length 103.77 🙂 103.60 🙂 -0.17 👍
Working memory 13.58 😞 13.61 😞 0.03 👎
Quality 55.94% 🙂 55.79% 🙂 -0.15% 👎
Other metrics Before After Change
Lines 1215 1212 -3
Changed files Quality Before Quality After Quality Change
deodr/differentiable_renderer.py 55.94% 🙂 55.79% 🙂 -0.15% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
deodr/differentiable_renderer.py Scene3D.render_deferred 16 🙂 663 ⛔ 27 ⛔ 19.96% ⛔ Try splitting into smaller methods. Extract out complex expressions
deodr/differentiable_renderer.py Scene3D._generate_scene_2d 6 ⭐ 395 ⛔ 20 ⛔ 32.91% 😞 Try splitting into smaller methods. Extract out complex expressions
deodr/differentiable_renderer.py Camera.project_points 8 ⭐ 218 ⛔ 23 ⛔ 35.50% 😞 Try splitting into smaller methods. Extract out complex expressions
deodr/differentiable_renderer.py Camera.project_points_backward 3 ⭐ 295 ⛔ 22 ⛔ 37.03% 😞 Try splitting into smaller methods. Extract out complex expressions
deodr/differentiable_renderer.py Scene2D.__init__ 0 ⭐ 231 ⛔ 25 ⛔ 41.84% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot force-pushed the sourcery/providing_pixel_fragments branch from 53a371d to 710dea0 Compare August 20, 2022 23:20
@sourcery-ai sourcery-ai bot force-pushed the sourcery/providing_pixel_fragments branch from 710dea0 to 2cb55bc Compare February 22, 2023 22:43
Comment on lines -186 to -189
fragments = differentiable_renderer_cython.renderSceneFragments(
return differentiable_renderer_cython.renderSceneFragments(
scene, sigma, z_buffer
)
return fragments
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function renderSceneFragments refactored with the following changes:

Comment on lines -650 to +649
fragments = renderSceneFragments(self, sigma, z_buffer)
return fragments
return renderSceneFragments(self, sigma, z_buffer)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Scene2D.render_fragments refactored with the following changes:

Comment on lines -985 to +983
fragments = self.scene_2d.render_fragments()
return fragments
return self.scene_2d.render_fragments()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Scene3D.render_fragments refactored with the following changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants