Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware for Referrer-Policy #259

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Add middleware for Referrer-Policy #259

merged 3 commits into from
Aug 13, 2024

Conversation

treagod
Copy link
Contributor

@treagod treagod commented Aug 8, 2024

This adds a new Referrer-Policy. If active the middleware will add a Referrer-Policy header to the response if not already defined

#244

@treagod treagod requested a review from ellmetha August 8, 2024 18:18
Copy link
Member

@ellmetha ellmetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! This looks good! I left a few suggestions and one question. We should be able to merge this afterward! 🙏

src/marten/conf/global_settings.cr Outdated Show resolved Hide resolved
src/marten/conf/global_settings.cr Outdated Show resolved Hide resolved
src/marten/conf/global_settings.cr Outdated Show resolved Hide resolved
src/marten/middleware/referrer_policy.cr Outdated Show resolved Hide resolved
@treagod treagod requested a review from ellmetha August 12, 2024 16:53
Copy link
Member

@ellmetha ellmetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellmetha ellmetha merged commit eb11629 into main Aug 13, 2024
70 checks passed
@ellmetha ellmetha deleted the referrer-policy branch August 13, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants