Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix primary cursor color display #1192

Merged
merged 1 commit into from
May 21, 2024

Conversation

terminalzeiro
Copy link

Since the last release (v0.9), my theme configuration has stopped working: the color of the primary selection cursor no longer matches the lexer.STYLE_CURSOR_PRIMARY setting.

This patch fixes this issue.

@mcepl
Copy link
Contributor

mcepl commented May 20, 2024

Could you please make it work with #1191 ?

@rnpnr
Copy link
Collaborator

rnpnr commented May 20, 2024

Hi! Can you give some example of the PRIMARY_CURSOR theming that is broken? Its possible that since I never use a different colour between cursors that it was missed.

Could you please make it work with #1191 ?

I could do that too. Its not that important.

@terminalzeiro
Copy link
Author

Hi! Can you give some example of the PRIMARY_CURSOR theming that is broken? Its possible that since I never use a different colour between cursors that it was missed.

sure, here is a screenshot...

vis-with-without-patch-primary-cursor-color

@rnpnr rnpnr merged commit 00e10a7 into martanne:master May 21, 2024
19 checks passed
@rnpnr
Copy link
Collaborator

rnpnr commented May 21, 2024

Yep, this seems correct so I applied it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants