Feature: shade colors by velocity #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gradient of colors will run from black for notes with zero velocity to the track or channel color (as selected by the user via the existing mechanism) for maximum velocity. This ended up looking nicer, conveying more information, and being easier to use than if we made "color notes by velocity" a completely separate mode than "color notes by track" and "color notes by channel".
|
I think I'd prefer a fully transparent -> black border around the notes. Would that work? |
|
We could also have a dotted-line border, and the distance between the dots indicates the velocity? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option for shading the colors by velocity
The gradient of colors will run from black for notes with zero velocity to the
track or channel color (as selected by the user via the existing mechanism) for
maximum velocity. This ended up looking nicer, conveying more information, and
being easier to use than if we made "color notes by velocity" a completely
separate mode than "color notes by track" and "color notes by channel".