Copy-pasting between multiple instances of MidiEditor #102
Conversation
spamming user clipboard with base64 string
|
Fixed tempo not being preseved across windows |
| @@ -37,6 +37,7 @@ | |||
| #include "math.h" | |||
|
|
|||
| #include <QtCore/qmath.h> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
classes and functions ain't used anywhere in that file
| channels[i] = new MidiChannel(this, i); | ||
| } | ||
|
|
||
| QDataStream* stream = new QDataStream(raw_midi); |
There was a problem hiding this comment.
We can add constructor from QDataStream to avoid code duplication
There was a problem hiding this comment.
I agree. There was already some duplication present before. Would probably make sense to fix all of this at once.
| MidiFile(QString path, bool* ok, QStringList* log = 0); | ||
| MidiFile(); | ||
| // needed to protocol fileLength | ||
| MidiFile(int maxTime, Protocol* p); | ||
| bool save(QString path); | ||
| QByteArray writeDeltaTime(int time); | ||
| QByteArray toByteArray(); | ||
| static QByteArray writeDeltaTime(int time); |
|
|
||
| if (copiedEvents->size() == 0) { | ||
| if(!ok){ |
There was a problem hiding this comment.
Fine... But how it can be false? Okay...
There was a problem hiding this comment.
Probably should never be false, but since the MidiFile constructor already has a check-mechanism, why not use it
|
|
||
| QByteArray copyFileBytes = copyFile.toByteArray(); | ||
| int MAX_COPY_SIZE = 1073741824; //1GB | ||
| if (copyFileBytes.size() > MAX_COPY_SIZE){ |
There was a problem hiding this comment.
Why do we have any MAX_COPY_SIZE? Is it a restriction of QSharedMemory or something?
There was a problem hiding this comment.
We should create buffer of some size, so we should set some size, MAX_COPY_SIZE in our case.
There was a problem hiding this comment.
The size of QSharedMemory needs to be specified before allocation, as far as i know. One can of course argue about what this size should be...
|
This would be a very cool feature to merge! |
This is currently not possible as copied events are simply stored in a variable of each instance of MidiEditor.
I added this feature by converting the selected events into a
MidiFileobject and saving this inQSharedMemory.When pasting, the reverse happens. See the commit message and the subsequent comment for more details.
This would resolve #84.