Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2294 Focus find-in-folder search box; unfocus with ESC #3421

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BBazard
Copy link

@BBazard BBazard commented Aug 21, 2022

Q A
Bug fix? yes
New feature? no
Breaking changes? no
Deprecations? no
New tests added? not needed
Fixed tickets Fixes #2294
License MIT

Description

This pull request changes the behavior of Edit: Find in Folder/(Ctrl+Shift+F) and View: Toggle Sidebar(Ctrl+J).

  • On Find in Folder: the search input is focused (whether the sidebar was previously open, closed or not yet created)
  • On Toggle Sidebar: when closing the sidebar the search input is unfocused (blurred) if it had the focus.
  • On Escape: the search input is unfocused (blurred) if it had the focus.

When the search input get focused, the search keyword is emptied. Which is the same behavior as 'Edit: Find'(Ctrl+F).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus find-in-folder search box; unfocus with ESC
1 participant