Add explicit nullable type to parameters. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12484812220Details
💛 - Coveralls |
|
Hi @friemt, Thanks for your interest in IterTools-PHP and thanks for the changes to for PHP 8.4 compatibility. Apologies in the delay in getting to this. These updates will go in the next release. Thanks again! |
|
Hi @markrogoyski Just wondering if you have a timeframe regarding the next release that will include this deprecation fix |
|
Sorry for the delay. I'll get to it this week. |
|
This has been released in the latest version, v1.9.0. Sorry for the delay and getting this out. |
|
Hey, no problem. Thanks for accepting the PR and pushing out a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php8.4 deprecated implicit nullable parameters. This PR updates function signatures to include
?-type where necessary.This change should not affect anything since the implementations already accounted for the parameters to be
null, only the correct type-hint was missing, which is a feature introduced in php7.1.