Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix bundler integration links #2066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

timothyr
Copy link

@timothyr timothyr commented Dec 2, 2023

Description

Fix the "supported bundlers" links to go to correct Marko docs page about bundler integrations

The links to bundler integrations don't redirect anywhere.
See current docs and click bundler link:
https://markojs.com/docs/cloudflare-workers/#bundler-integrations

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Dec 2, 2023

⚠️ No Changeset found

Latest commit: 9be1046

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@timothyr
Copy link
Author

timothyr commented Mar 7, 2024

rebased

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timothyr, sorry for the long delay. After this minor fix we can merge.

@@ -29,4 +29,4 @@ async function handleRequest(request) {
### BYOB (Bring your own bundler)

For the large portion of Marko's API a bundler is required. The example code above assumes that Marko templates can be loaded in your environment.
Marko supports a number of bundlers, [take a look through our supported bundlers](#bundler-integrations) and pick what works best for you.
Marko supports a number of bundlers, [take a look through our supported bundlers](https://markojs.com/docs/bundler-integrations-overview/) and pick what works best for you.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on second look these should be relative paths.

Suggested change
Marko supports a number of bundlers, [take a look through our supported bundlers](https://markojs.com/docs/bundler-integrations-overview/) and pick what works best for you.
Marko supports a number of bundlers, [take a look through our supported bundlers](/docs/bundler-integrations-overview/) and pick what works best for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants