fix(MCOL-4942): No-table-SELECT now can return empty set #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query like "SELECT 1 WHERE 1=0" was returning a row despite unsatisfiable condition in WHERE. Now it returns an empty set.
mariadb-LeonidFedorov
approved these changes
Feb 21, 2025
drrtuy
reviewed
Feb 21, 2025
| TupleConstantOnlyStep::TupleConstantOnlyStep(const JobInfo& jobInfo) : TupleConstantStep(jobInfo) | ||
| TupleConstantOnlyStep::TupleConstantOnlyStep(const JobInfo& jobInfo) | ||
| : TupleConstantStep(jobInfo) | ||
| , fEmptySet(jobInfo.constantFalse) |
There was a problem hiding this comment.
I would call this impossible condition b/c there are a variety of reasons when empty set can delivered.
There was a problem hiding this comment.
I do not get it. Can you explain?
drrtuy
reviewed
Feb 21, 2025
| ( | ||
|
|
||
| SELECT NULL ID WHERE 1111=2222 | ||
|
|
There was a problem hiding this comment.
I have moved reproduction query into the test as it is. That's why there are extra empty lines.
drrtuy
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query like "SELECT 1 WHERE 1=0" was returning a row despite unsatisfiable condition in WHERE. Now it returns an empty set.