Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCOL-5852: use only long string storage for the group_concat data to reduce memory usage #3408

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mariadb-AlexeyAntipovsky
Copy link
Contributor

No description provided.

@mariadb-LeonidFedorov mariadb-LeonidFedorov changed the title use only long string storage for the group_concat data to reduce memory usage MCOL-5852: use only long string storage for the group_concat data to reduce memory usage Feb 19, 2025
@mariadb-LeonidFedorov
Copy link
Collaborator

please fix compile errors from clang (debian 11)

make[4]: Leaving directory '/mdb/verylongdirnameforverystrangecpackbehavior/builddir'

In file included from /mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/common/statistics.cpp:27:

In file included from /mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/common/./statistics.h:20:

/mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/rowgroup/rowgroup.h:1523:8: error: 'serialize' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

  void serialize(messageqcpp::ByteStream&) const;

       ^

/mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/messageqcpp/serializeable.h:50:16: note: overridden virtual function is here

  virtual void serialize(ByteStream&) const = 0;

               ^

In file included from /mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/common/statistics.cpp:27:

In file included from /mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/common/./statistics.h:20:

/mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/rowgroup/rowgroup.h:1524:8: error: 'deserialize' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

  void deserialize(messageqcpp::ByteStream&);

       ^

/mdb/verylongdirnameforverystrangecpackbehavior/storage/columnstore/columnstore/utils/messageqcpp/serializeable.h:54:16: note: overridden virtual function is here

  virtual void deserialize(ByteStream&) = 0;

               ^

@mariadb-AlexeyAntipovsky
Copy link
Contributor Author

Fixed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants