[DNM] MCOL-5638 Improve Client Error Messaging and async broadcasting config. #3400
+364
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mariadb-AlanMologorsky
commented
Feb 7, 2025
mariadb-AlanMologorsky
commented
- fix(Cmapi): broadcast_new_config function using aiohttp and improved errors handling mechanics
- fix(Cmapi): requirements updating aiohttp version and it's dependencies
- fix(Cmapi, deps): unused imports
[add] cluster api client class [fix] cli cluster_app using cluster api client [add] ClusterAction Enum [add] toggle_cluster_state function to reduce code duplication
[fix] client class methods [fix] Transaction management at endpoint handling level [fix] add_node and set_mode methods to use TransactionManager
MAJOR: Some logic inside node remove changed significantly using active
nodes list from Columnstore.xml to broadcast config after remove.
[fix] remove node logic to use Transaction manager
[fix] cluster set api key call using totp on a top level cli call
[add] missed docstrings
…asting config. * fix(Cmapi): broadcast_new_config function using aiohttp and improved errors handling mechanics * fix(Cmapi): requirements updating aiohttp version and it's dependencies * fix(Cmapi, deps): unused imports
mariadb-AlanMologorsky
changed the title
drrtuy
reviewed
Feb 21, 2025
| if error_messages: | ||
| errors_str = ', '.join(error_messages) | ||
| final_message = ( | ||
| f'Broadcasting config to nodes failed with errors: {errors_str}' |
There was a problem hiding this comment.
That would be helpful to have nodes ids here together with the corresponding errors.
drrtuy
requested changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.