[DNM] MCOL-5133: Stage3 stand alone cli tool. #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariadb-AlanMologorsky
changed the title
drrtuy
reviewed
Feb 9, 2025
drrtuy
reviewed
Feb 9, 2025
| ) | ||
| response.raise_for_status() | ||
| return response.json() | ||
| # TODO: different handler for timeout exception? |
There was a problem hiding this comment.
Good idea.
Could you point me where do we release the lock if something went south during execution of a command on a cluster ?
There was a problem hiding this comment.
Api client itself just calling remote endpoint, thansaction mechanics never used here. Otherwise it's used on a top level. For eg. here
[add] cluster api client class [fix] cli cluster_app using cluster api client [add] ClusterAction Enum [add] toggle_cluster_state function to reduce code duplication
[add] cluster api client class [fix] cli cluster_app using cluster api client [add] ClusterAction Enum [add] toggle_cluster_state function to reduce code duplication
[fix] client class methods [fix] Transaction management at endpoint handling level [fix] add_node and set_mode methods to use TransactionManager
mariadb-AlanMologorsky
force-pushed
the
feature/MCOL-5133-stage3-stand-alone-cli
branch
2 times, most recently
from
3a8c85b to
f6c2a17
Compare
MAJOR: Some logic inside node remove changed significantly using active
nodes list from Columnstore.xml to broadcast config after remove.
[fix] remove node logic to use Transaction manager
[fix] cluster set api key call using totp on a top level cli call
[add] missed docstrings
[fix] cluster shutdown timeout for next release
mariadb-AlanMologorsky
force-pushed
the
feature/MCOL-5133-stage3-stand-alone-cli
branch
from
f6c2a17 to
8591b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAJOR: Some logic inside node remove changed significantly using active
nodes list from Columnstore.xml to broadcast config after remove.