-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.6 added jenkins install option for dev & dependency check & user if exists checks for cluster install #3328
base: develop
Are you sure you want to change the base?
Conversation
…creation on cluster install
…_v3.5 merge develop into cs_package_manager_v3.5
|
||
# Use telnet to check port 8640 on replica nodes | ||
for node in $(echo $nodes | tr "," "\n"); do | ||
counter=0 | ||
printf "%-35s ..." " - Checking cmapi port 8640 on $node " | ||
while true; do | ||
|
||
if telnet $node 8640 < /dev/null 2>&1 | grep -q 'Connected'; then | ||
if timeout $timeout_seconds telnet $node 8640 < /dev/null 2>&1 | grep -q 'Connected'; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here mcs cmapi is-ready --node $node
could be useful here.
But it depends on which version of cmapi installed.
@@ -1361,15 +1611,67 @@ quick_version_check() { | |||
fi | |||
} | |||
|
|||
check_columnstore_install_dependancies() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependancies -> dependencies
case $distro_info in | ||
centos | rhel | rocky ) | ||
|
||
package_list=("python3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI: In some rare cases it could be potentially harmful here.
Load and save brm scripts optimized for python 3.6.8 and above. If python3 version is lower it could cause undefined behavior.
;; | ||
ubuntu | debian ) | ||
|
||
package_list=("python3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like duplication of line 1619. I think it could be moved above case
statement on 1616 line.
fi | ||
|
||
# Install MariaDB Server | ||
if ! yum install MariaDB-server-* galera-enterprise-* MariaDB-client-* MariaDB-common-* MariaDB-shared-* -y; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It installs debuginfo packages too. Is it expected?
apt-get clean | ||
DEBIAN_FRONTEND=noninteractive sudo apt install gawk libdbi-perl lsof perl rsync -y --quiet | ||
DEBIAN_FRONTEND=noninteractive sudo apt install libdbi-perl socat libhtml-template-perl -y --quiet | ||
if ! DEBIAN_FRONTEND=noninteractive apt install $(pwd)/mysql-common*.deb $(pwd)/mariadb-server*.deb $(pwd)/galera-enterprise-* $(pwd)/mariadb-common*.deb $(pwd)/mariadb-client-*.deb $(pwd)/libmariadb3*.deb -y --quiet; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It installs dbgsym packages too. Is it expected?
# Check if each expected RPM exists | ||
missing_rpms=() | ||
for rpm in "${expected_packages[@]}"; do | ||
if ! ls ${rpm_deb_files_directory}/*${rpm}*.rpm 1> /dev/null 2>&1; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are debuginfo packages. So potentially it could be false positive results here.
@@ -2457,10 +3170,33 @@ do_upgrade() { | |||
|
|||
} | |||
|
|||
prompt_user_for_cpu_architecture(){ | |||
# Prompt the user to select an operating system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*CPU architecture
@@ -2457,10 +3170,33 @@ do_upgrade() { | |||
|
|||
} | |||
|
|||
prompt_user_for_cpu_architecture(){ | |||
# Prompt the user to select an operating system | |||
echo "Please select a CPU architecture:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be done without promting user.
Using os-release
or uname -m
for Mac systems.
No description provided.