-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prop for fixed selection dot and fadeout starting point. #97
base: main
Are you sure you want to change the base?
Conversation
@mrousavy would you be interested in merging this enhancement? |
Hey - yep, I am! I'm just waiting for @chrispader to get back from vacation, as he's the main responsible maintainer for RN Graph nowadays :) |
thanks for your PR on this!! |
Cool! Thanks for letting me know. Will continue any further discussion and ideas with him |
I have been using this, as well as @gabimoncha 's forked CustomIndicator component PR would be good to get these merged The only ammendment would be the logic in the AnimatedLineGraph.tsx circa line 535, if an indicator component is used then the indicator pulsing is disabled it would be good to have both, just duplicating the indicatorPulsing into your ternary operator conditional works well enough, see below. I can submit a PR if needed gabi :) (IndicatorComponent != null ? (
<Group>
{indicatorPulsating && (
<Circle
cx={indicatorX}
cy={indicatorY}
r={indicatorPulseRadius}
opacity={indicatorPulseOpacity}
color={indicatorPulseColor}
style="fill"
/>
)}
<IndicatorComponent
isActive={isActive}
color={color}
circleX={indicatorX}
circleY={indicatorY}
/>
</Group>
|
I'm gonna try to look into this issue (and others) on the weekend or next week. Unfortunately i'm fully booked with work right now... |
@chrispader let me know if you need any help to streamline this :D |
any chance we can get these merged? @chrispader as well as @gabimoncha's other forked repo containing the custom indicatordot? |
@theblondealex @chrispader - I have another one where I pass the index of the data point to onPointSelected in case you want to use it for additional visualisation in a larger dataset object 😅 |
i'm gonna look into this tmrw! sorry for the delay...
@gabimoncha could you provide me a link to that? |
@chrispader - here
|
@chrispader any updates on this PR? would love to push the other solutions too |
selectionDotValueX
prop for a fixed position of the selection dotfadeouValueX
prop for a fixed starting point for the fade outSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-02.at.14.25.24.mp4