Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop for fixed selection dot and fadeout starting point. #97

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gabimoncha
Copy link

  1. Update C++ standard to c++17
  2. Update Cocoapods version to latest stable
  3. Add selectionDotValueX prop for a fixed position of the selection dot
  4. Add fadeouValueX prop for a fixed starting point for the fade out
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-02.at.14.25.24.mp4

@gabimoncha
Copy link
Author

gabimoncha commented Mar 12, 2024

@mrousavy would you be interested in merging this enhancement?

@mrousavy
Copy link
Member

Hey - yep, I am! I'm just waiting for @chrispader to get back from vacation, as he's the main responsible maintainer for RN Graph nowadays :)

@mrousavy
Copy link
Member

thanks for your PR on this!!

@gabimoncha
Copy link
Author

Cool! Thanks for letting me know. Will continue any further discussion and ideas with him

@theblondealex
Copy link

theblondealex commented Mar 27, 2024

I have been using this, as well as @gabimoncha 's forked CustomIndicator component PR would be good to get these merged

The only ammendment would be the logic in the AnimatedLineGraph.tsx circa line 535, if an indicator component is used then the indicator pulsing is disabled it would be good to have both, just duplicating the indicatorPulsing into your ternary operator conditional works well enough, see below. I can submit a PR if needed gabi :)

 (IndicatorComponent != null ? (
                  <Group>
                    {indicatorPulsating && (
                       <Circle
                         cx={indicatorX}
                         cy={indicatorY}
                         r={indicatorPulseRadius}
                         opacity={indicatorPulseOpacity}
                         color={indicatorPulseColor}
                         style="fill"
                       />
                     )}
                  <IndicatorComponent
                    isActive={isActive}
                    color={color}
                    circleX={indicatorX}
                    circleY={indicatorY}
                  />
                  </Group>
 

@chrispader
Copy link
Member

I'm gonna try to look into this issue (and others) on the weekend or next week. Unfortunately i'm fully booked with work right now...

@gabimoncha
Copy link
Author

@chrispader let me know if you need any help to streamline this :D

@theblondealex
Copy link

any chance we can get these merged? @chrispader as well as @gabimoncha's other forked repo containing the custom indicatordot?

@gabimoncha
Copy link
Author

@theblondealex @chrispader - I have another one where I pass the index of the data point to onPointSelected in case you want to use it for additional visualisation in a larger dataset object 😅

@chrispader
Copy link
Member

i'm gonna look into this tmrw! sorry for the delay...

@theblondealex @chrispader - I have another one where I pass the index of the data point to onPointSelected in case you want to use it for additional visualisation in a larger dataset object 😅

@gabimoncha could you provide me a link to that?

@gabimoncha
Copy link
Author

@chrispader - here
Each branch is a different feature for the app. The ones I told you on discord too

  1. Custom starting point for selection dot. this PR
  2. Custom Indicator - same props as SelectionDot.
  3. Passing the index in onPointSelected, if needed to link data point to a bigger data set

@gabimoncha
Copy link
Author

gabimoncha commented Apr 30, 2024

@chrispader any updates on this PR? would love to push the other solutions too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants