Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new parameter in the main function: outer_scaler #217

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Larryliu912
Copy link

It will read a sklearn.preprocessing.StandardScaler() class. Sometimes we will preprocess the data, StandardScaler() is an easy way, but we don't want data displayed in a standardized way -- human cannot understand it! So I modified some functions to solve this problem. At the same time, outer_scaler was set as None default, won't create conflict.

… read a StandardScaler() class. Sometimes we will do some precessing of the data, but we don't want to data displayed in a standarized way -- human cannot understand it! So I fix some functions to solve this problem. At the sametime, this outer_scaler was set as None default, won't create conflict.
@marcotcr
Copy link
Owner

Sorry, I'm a little lost as to the main purpose of having this 'outer_scaler'. If the purpose is just to let users have more control over discretization, wouldn't it be better for them to just discretize the data ahead of time?

@eamonjohnson
Copy link

I think the point here is to present the explanation in terms of the source data (pre-scaling), as opposed to presenting the explanation in terms of the scaled data (post-scaling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants