This repository was archived by the owner on Jan 11, 2021. It is now read-only.
Fix of a bug that happens when the user defines prototype functions for Array#729
Open
andreyyudin wants to merge 3 commits intomarcgibbons:masterfrom
Open
Fix of a bug that happens when the user defines prototype functions for Array#729andreyyudin wants to merge 3 commits intomarcgibbons:masterfrom
andreyyudin wants to merge 3 commits intomarcgibbons:masterfrom
Conversation
…is case the original code would go through all those functions and treat them as parameters, rather than working only on the actual content of an array. For example, having Array.prototype.last = function(){... defined would result in one of the elements of sharedParameters to represent that function, which in turn would lead to a problem on line 329 since for such a parameter, param.schema would be undefined
victorcmoura
suggested changes
Nov 28, 2018
victorcmoura
left a comment
victorcmoura
left a comment
There was a problem hiding this comment.
Thank you for your contribution, well pointed. However, in my opinion, there could be a single line comment explaining why the old school for loop should not be replaced by for i in object, it would prevent future contributors from rolling back your improvement in case the reviewer is not aware of this issue.
…le rollbacks to the old code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of an issue of having prototype Array function definitions. In this case the original code would go through all those functions and treat them as parameters, rather than working only on the actual content of an array. For example, having
Array.prototype.last = function(){...
defined would result in one of the elements of sharedParameters to represent that function, which in turn would lead to a problem on line 329 since for such a parameter, param.schema would be undefined.
Also, a couple of small cosmetic adjustments of the code.