Skip to content

Update poetry to 2.1.3 #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Update poetry to 2.1.3 #586

merged 1 commit into from
May 22, 2025

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented May 22, 2025

This repository is currently using poetry 1.6.1, released in August 2023. A lot has changed in Python packaging since then, including the crystallization of the pyproject.toml standard metadata, dependency groups, and more.

This PR gets ready for revitalizing SSSOM-py by first updating Poetry to a newer version. This makes a small amount of diff in the poetry lock file.

Note: poetry fixed its resolver since 1.6.1 and it's also muchhhh faster now

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was not aware that its best practice to hard code the poetry version but seems it is. I will approve.

@matentzn matentzn merged commit c99be4d into master May 22, 2025
8 checks passed
@matentzn matentzn deleted the update-poetry branch May 22, 2025 11:14
@matentzn
Copy link
Collaborator

THANK YOU @cthoyt for your contribution!!

@cthoyt
Copy link
Member Author

cthoyt commented May 22, 2025

I don't know if it's best practice or not. I would rather not do it and rely on the most recent version, but I didn't want this update to be controversial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants