Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create base from UI #1142

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

tomeronen
Copy link
Contributor

Starting to build the UI step by step. This is the first step contains basic setup discussions about the libraries to use, and building the code as part of the martin build and serving it from the binariy :

  • js library - React with TS: Both kepler.gl and Maputnik are written in react. Which can make bringing them in some way to this UI easier.
  • bundler - vite.
  • styling - styled-components my personal favourite (and used by kepler.gl so we will be able to easily learn from what they have done)

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, and we need some sort of a basic "smoke test" in CI - something that will check if webui is actually loading properly - perhaps add a simple test to curl / and some asset (whose name does not change)?

@@ -0,0 +1,30 @@
# React + TypeScript + Vite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs updating - I would prefer not to check in unrelated boilerplate readme

@@ -0,0 +1,20 @@
import martinCover from './assets/martin-cover.png'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image is somewhat incorrect - martin is not only focused on large databases... Not sure what to say there - maybe even leave it at empty-ish, or use the martin's main documentation string?

@@ -96,6 +104,15 @@ pub fn router(cfg: &mut web::ServiceConfig) {

#[cfg(feature = "fonts")]
cfg.service(crate::srv::fonts::get_font);

#[cfg(feature = "webui")]
cfg.service(actix_web_static_files::ResourceFiles::new(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a subtle bug here - compiled files go into /assets/... - but the word assets could also be the name of a tile source. Is there a way we can make the root /index.html use /_/assets/... path instead? The _ is a reserved keyword, so we should put everything non-stable there.

@nyurik
Copy link
Member

nyurik commented Feb 2, 2024

@tomeronen i merged in the changes from the main branch. Let me know if you need any help with this

@nyurik nyurik mentioned this pull request Feb 14, 2024
@nyurik
Copy link
Member

nyurik commented Mar 17, 2024

FYI, Maputnik has been moved to maplibre, and so is the maplibre-gl-inspect, with lots of work being done on them. Any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants