Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: early draft PR for SLAM #611

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Conversation

fabianschenk
Copy link
Contributor

@fabianschenk fabianschenk commented Jun 15, 2020

This is a draft PR for SLAM, with all the basic modules.
It includes our new data structures and Yann's camera models.

Open issues:

  • API naming
  • Code clean-up
  • Run script similar to bin/opensfm_run_all
  • More SLAM unit tests
  • Check fusion with non-local Landmarks (add more comments)
  • PyPangolin SLAM visualization

@fabianschenk fabianschenk marked this pull request as draft June 15, 2020 16:26
@fabianschenk fabianschenk self-assigned this Jun 15, 2020
@facebook-github-bot
Copy link
Contributor

Hi @fabianschenk!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants