Account for not-unique source masked values #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose a user inputs an array where masked values are not all unique (e.g. user is matching histograms for .tif red raster band with nodata value of 0. When rastertio.open() reads the .tif, machine epsilon may code some zeros a little bit off, like say 0.00000000001. Then the mask will cover 0 and 0.00000000001). Then, before the insertion of this edit, mask_index[0] would contain more than one value, and everything breaks. My edit replaces all masked values with np.nan up front to ensure np.unique (line 53) records only one masked value, thus preserving the mask_index[0] system below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose a user inputs an array where masked values are not all unique (e.g. user is matching histograms for .tif red raster band with nodata value of 0. When rastertio.open() reads the .tif, machine epsilon may code some zeros a little bit off, like say 0.00000000001. Then the mask will cover 0 and 0.00000000001). Then, before the insertion of this edit, mask_index[0] would contain more than one value, and everything breaks. My edit replaces all masked values with np.nan up front to ensure np.unique (line 53) records only one masked value, thus preserving the mask_index[0] system below.