Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.0-beta.1 #13173

Merged
merged 63 commits into from
May 10, 2024
Merged

v3.4.0-beta.1 #13173

merged 63 commits into from
May 10, 2024

Conversation

underoot
Copy link
Member

@underoot underoot commented May 10, 2024

Features and improvements ✨

  • Add icon-color-saturation, icon-color-contrast, icon-color-brightness-min and icon-color-brightness-max to control symbol layer appearance.
  • Introduce a new line-join mode: none to improve line pattern distortions around joins.
  • Extend model-id property to support URIs (in addition to style-defined model references).

Bug fixes 🐞

  • Respect padding in cameraForBounds on globe view. (h/t @jonasnoki) #13126
  • Fix preloadOnly not preloading tiles from style imports.
  • Fix queryRenderedFeatures for non-integer ID in non-tiled model sources
  • Fix model-scale property for large number of 3D models.
  • Fix flickering of raster-particle layer on globe view.
  • Improve rendering of low-resolution raster-array data.

underoot and others added 30 commits May 8, 2024 18:09
* Add `preloadOnly` support for the style imports

* Add unit tests
…l models not declared in the style. For example declared in the geojson model layer (internal-1298)
* Check for scope on ModelManager#addModels

* Add unit tests
* Use named import for the Map class

* Fix imports
…layer. (internal-1314)

* Modify the existing icon-color-saturation and provide additional properties to be able to adjust contrast and brightness of the icons as well

* apply alpha after color adjustment

* render tests

* codegen fix

* hue rotate

* refactor func to util

* remove hue rotate

* contrast factor avoid degenerate case

* allowed test threshold
Bumps [testem](https://github.com/testem/testem) from 3.12.0 to 3.13.0.
- [Release notes](https://github.com/testem/testem/releases)
- [Commits](testem/testem@v3.12.0...v3.13.0)

---
updated-dependencies:
- dependency-name: testem
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 22.6.3 to 22.6.5.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-core-v22.6.3...puppeteer-core-v22.6.5)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [playwright](https://github.com/microsoft/playwright) from 1.43.0 to 1.43.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.43.0...v1.43.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html) from 8.0.0 to 8.1.0.
- [Changelog](https://github.com/BenoitZugmeyer/eslint-plugin-html/blob/main/CHANGELOG.md)
- [Commits](BenoitZugmeyer/eslint-plugin-html@v8.0.0...v8.1.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-html
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Improve Flow typings

* Move GridIndex to types/grid-index.js

* Use TrackedParametersMock
Models where not being correctly uploaded/updated
* Improve Flow typings

* Add ITrackedParameters

* Style#isLayerDraped -> StyleLayer#isDraped
* Move shader variable declarations outside of #ifdefs

* Add dummy gl_Position to fix invalid input to metal shader compilation
* Use `tracked_parameters_proxy` for  TP types
…on (internal-1339)

* avoid duplicated bounding box calculations in convertFootprint function

* remove redundant array allocations

* unit test

* further move back the aabb calculations and only pass it down to TriangleGridInex instead

* Revert "further move back the aabb calculations and only pass it down to TriangleGridInex instead"

This reverts commit 98284fce40f7a2418eddd3a96dbf82a14ad3c05c.
* Improve Flow typings

* Improve Flow typings

* Fix controls

* Fix controls

* Add real-world TypeScript+Webpack test

* Export more types explicitly

* Drop type exports
* Fix model scope for models defined in style (basemap or other imports). Incidentally fixed also trees flickering by removing the style.uploaded clause that was wrongly added

* Check for 404 models

* Limit model uris to urls

It was difficult to identify correctly relative URIs and avoid collision with models defined in style. So the most straightforward decision is to only allow URLs, the same as TileJson

* Add parameter to isValidUrl to allow/disallow relativeUrls
Bumps [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html) from 8.1.0 to 8.1.1.
- [Changelog](https://github.com/BenoitZugmeyer/eslint-plugin-html/blob/main/CHANGELOG.md)
- [Commits](BenoitZugmeyer/eslint-plugin-html@v8.1.0...v8.1.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-html
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
underoot and others added 25 commits May 8, 2024 18:09
* Updated to Vitest 1.5

* Migrated to Playwright image

* Updated Vitest and fixed tests and description

* Reverted skip of performance_metrics.test.js

* Reverted skip of model_layer.test.js

* Added specified version of Node.js

* Updated README and removed useless script

* Added description to steps

* Reverted to original approach
Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.24.1 to 7.24.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.5/eslint/babel-eslint-parser)

---
updated-dependencies:
- dependency-name: "@babel/eslint-parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Shadows and lighting need to use tileModelMatrix instead of nodeModelMatrix
* Render particles using position textures

* Update render-test expectations

* Metal shader accommodations

* Control particle position encoding using a single set of parameters
* Add line-pattern debug page
* Improvements for line-pattern
…ernal-1372)

This reverts commit a988bcb1ff5a358ff2d8ad40099a69d5c01adb82.
- Add new join mode line-join: none
- When line-pattern is used with line-join: none, render line so that incomplete pattern cycles in line segments are not shown
…date, support integer and non-numeric ids (internal-1374)

* [MAPS3D-1257][MAPS3D-1342] upload instance buffer on feature state update, support integer and non-numeric ids

trees.geojson has ids defined like e.g. "id": 4

This triggered the issue similar to nonnumeric ids since id was not parsed (only e.g. "id": "4" works, "id"L 4, doesn't).
Extended the id set with non numeric "3a" and this also resolved the query issue experienced by maps people. Now, for queryRenderedFeatures, this doesn't solve issue with querying features that have no ids, but only for non-integer ids (MapsPeople).
instanced buffer needs to get reuploaded after feature state change to resolve MAPS3D-1257.

* update expected after duplicated id 3 is renamed to "3a"
Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@16.4.0...16.5.0)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser) from 1.5.2 to 1.6.0.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v1.6.0/packages/browser)

---
updated-dependencies:
- dependency-name: "@vitest/browser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 22.7.1 to 22.8.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-core-v22.7.1...puppeteer-core-v22.8.0)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 20.1.0 to 20.1.1.
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](octokit/rest.js@v20.1.0...v20.1.1)

---
updated-dependencies:
- dependency-name: "@octokit/rest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [is-builtin-module](https://github.com/sindresorhus/is-builtin-module) from 3.2.1 to 4.0.0.
- [Release notes](https://github.com/sindresorhus/is-builtin-module/releases)
- [Commits](sindresorhus/is-builtin-module@v3.2.1...v4.0.0)

---
updated-dependencies:
- dependency-name: is-builtin-module
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@underoot underoot requested a review from a team as a code owner May 10, 2024 08:29
3d-style/render/model_manager.js Dismissed Show dismissed Hide dismissed
3d-style/render/model_manager.js Dismissed Show dismissed Hide dismissed
@underoot underoot merged commit be50cec into main May 10, 2024
30 checks passed
@underoot underoot deleted the release/3.4.0-beta.1 branch May 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants