Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render text files, scan all files, all files show up in list #1143

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ksuquix
Copy link
Collaborator

@ksuquix ksuquix commented Mar 31, 2023

Resolves #764

@ksuquix ksuquix marked this pull request as draft March 31, 2023 06:18
@Floppy
Copy link
Collaborator

Floppy commented May 17, 2023

@ksuquix are you happy for this to be reviewed yet, or is it still WIP?

@ksuquix
Copy link
Collaborator Author

ksuquix commented May 17, 2023 via email

@Floppy Floppy added the feature User-facing features and product enhancements label Jun 13, 2023
@ToasterUwU
Copy link
Contributor

Would this also improve the way it shows files?
My issue currently is that it shows things but not tells me what are printable files and what are just images. So everything is just bunched together, leading to the need to skim over the files and find the printable ones.

Also, I'm sure this fixes this, but currently, there is no way to download scad files from things if they are included. I would have to physically open and manually find the location where it saves the files.

@Floppy
Copy link
Collaborator

Floppy commented Sep 21, 2023

@ToasterUwU that probably falls under #1069 or #50, I think, rather than this one, although I'm not sure where @ksuquix was heading with this, so perhaps that's the intent. I'll open another ticket for SCAD support, which I can probably get in sooner than this.

@ksuquix
Copy link
Collaborator Author

ksuquix commented Sep 21, 2023 via email

@ToasterUwU
Copy link
Contributor

@ksuquix Hey, don't wanna stress you out. But any idea for an ETA for this?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Floppy
Copy link
Collaborator

Floppy commented Feb 5, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is a new thing I've added as part of my "getting organised". Don't panic 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements
Projects
Status: One Day
Development

Successfully merging this pull request may close these issues.

Index all files in model directory
4 participants