Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disqus #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for disqus #87

wants to merge 2 commits into from

Conversation

seeeturtle
Copy link
Collaborator

No description provided.

@seeeturtle
Copy link
Collaborator Author

@manu-chroma, it seems disqus refuse user-agent of requests.
I'll merge it after the PR that uses Session is merged.

@seeeturtle
Add support for disqus
7502ccc 
This will add support for disqus.

Closes manu-chroma#83
@seeeturtle
Modify User-Agent to User-Agent of Chrome
52e49e3 
Since disqus refuses user agent of requests,
We should modify its user agent to user agent of Chrome
which is a popular browser.
@seeeturtle
Copy link
Collaborator Author

@manu-chroma , It seems User-Agent isn't the only one to get the real content from disqus...

And I can't understand why medium test fails.

@manu-chroma
Copy link
Owner

oh man, this is disappointing

@manu-chroma
Copy link
Owner

i think our safe bet is to drop medium avatar support to be honest.

it doesn't seem worth so much effort

@seeeturtle
Copy link
Collaborator Author

@manu-chroma , yeah, medium is too unpredictable...
we should support medium avatar if there is way to get avatar url constantly...

btw, I think we should split the get_avatar_test to

  1. no image found
  2. returns different url.(the requests should be sent more than 2)

@seeeturtle
Copy link
Collaborator Author

I think the basic solution is to use api to provide constant result...(if we can)

@seeeturtle
Copy link
Collaborator Author

🤔 I think I saw wrong thing.
There's no error from medium. It's working well.

But still it's true that the basic solution is using api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seeeturtle @manu-chroma