templates/form.html: Improve "Made with love.." #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsh2102
suggested changes
Nov 24, 2018
templates/form.html
Outdated
| @@ -86,7 +86,7 @@ <h1 class = "title" >Username Availability Checker</h1> | |||
| </div> | |||
| </div> | |||
| <div class="footer"> | |||
| Made with love in New Delhi. | |||
| <p>Made by <span><a href="https://github.com/manu-chroma/username-availability-checker/graphs/contributors"> Google Code-In mentors and students</a></span> of coala, from all around the world.</p> | |||
There was a problem hiding this comment.
Hey,
There seems to be a redundant space here.
You may remove the space after the href attribute; before Google Code-In.
There was a problem hiding this comment.
Suggested change
| <p>Made by <span><a href="https://github.com/manu-chroma/username-availability-checker/graphs/contributors"> Google Code-In mentors and students</a></span> of coala, from all around the world.</p> | |
| <p>Made by <span><a href="https://github.com/manu-chroma/username-availability-checker/graphs/contributors"> Google Code-In mentors and students</a></span> of coala and some other good friends, from all around the world.</p> |
There have been some contributors too. I think this one's a little better 😉
utkarsh2102
suggested changes
Nov 25, 2018
There was a problem hiding this comment.
Haha, we have more errors this time.
See the log, there are trailing whitespaces.
Just do a proper indentation, that will fix it, IMHO.
Do something like this:
- Make the whole line into 3 parts.
- 1st and 3rd for
<p>and</p>, respectively. - 2nd is for the rest.
This will work.
Ping me if you still need help.
This PR tends to improve "Made in love.." at the end of the website. Closes manu-chroma#124
utkarsh2102
approved these changes
Nov 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tends to improve "Made in love.." at the end of the website.
Closes #124