Update gamma correction to use updated algorithm #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantid's algorithm for gamma correction was recently updated to correct a bug where output workspaces would not preserve the order of the spectra. Now that this is fixed, we can avoid using a for loop for the gamma correction algorithm.
src/mvesuvio/analysis_reduction.py
Outdated
| @@ -995,24 +995,9 @@ def create_gamma_workspaces(self): | |||
| profiles = self.calcGammaCorrectionProfiles(self._mean_widths, self._mean_intensity_ratios) | |||
|
|
|||
| # Approach below not currently suitable for current versions of Mantid, but will be in the future | |||
There was a problem hiding this comment.
Is this comment still valid? The fix for VesuvioCalculateGammaBackground was merged end of 2023, so it should be available in current versions of Mantid.
There was a problem hiding this comment.
I am talking about the comment "# Approach below not currently suitable for current versions of Mantid, but will be in the future".
There was a problem hiding this comment.
Ah yes I forgot to remove it, thanks for spotting it!
SilkeSchomann
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mantid's algorithm for gamma correction was recently updated in to correct a bug where output workspaces would not preserve the order of the spectra.
Now that this is fixed, we can avoid using a for loop for the gamma correction algorithm.
Description of work:
Uncommented part of code that I had written in the past to be in place once the update went in.
To test:
Look at the code and make sure the analysis system tests passed.
Fixes #xxxx.