-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More changes to size_t and int64_t types #38939
Conversation
👋 Hi, @rboston628, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
cecc137
to
189e7fe
Compare
9bdfe5c
to
6ff5bd8
Compare
👋 Hi, @rboston628, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
6ff5bd8
to
a186a7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fairly mechanical changes to follow what has happened in NexusClasses
…anges More changes to size_t and int64_t types
Description of work
Summary of work
NexusClasses
was originally written to work withnapi,h
, which uses standardint
for all integer quantities. However, some of these quantities are better expressed assize_t
. Some are better expressed assize_t
but can't due to some compatibility expectations for negative numbers, and must beint64_t
.It seems some places in code were constrained by this limitation of
NexusClasses
to useint
s. Several of these places were fixed by resetting types to a more appropriate type.This should improve the overall code quality of Mantid, by allowing for easier setting of whole counting numbers with unsigned int types, or at least with double width ints.
Part of #38332
Compare and/or combine with #38805
Further detail of work
There should be no changes in this PR, except for:
int
changed tosize_t
orint64_t
size_t
and a<0
check fixed to avoid compiler and CppCheck warningsThis does not require release notes because it is an internal change invisible to users.
To test:
Make sure all existing tests pass.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.