Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for CalibrationInfo #38894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andy-bridger
Copy link
Collaborator

Description of work

Summary of work

Added some very lightweight Unit Tests to test the CalibrationInfo class

Fixes #38888 .

Further detail of work

Having looked more into it, I can see why there was no testing before - most of the functions are essentially if statements that link to different ws loaders or creators. I have just added coverage that checks that the different groups follow the correct paths through the logic. This is mainly for peace of mind when I start extending the Engineering Diffraction Interface for pole figures

To test:

See if it passes all unit tests and that these new ones have been included. Check if there is any other functionality that can be tested automatically


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@andy-bridger andy-bridger marked this pull request as ready for review February 19, 2025 15:50
@andy-bridger andy-bridger added this to the Release 6.13 milestone Feb 20, 2025
@andy-bridger andy-bridger added Diffraction Issues and pull requests related to diffraction Maintenance Unassigned issues to be addressed in the next maintenance period. labels Feb 20, 2025
@warunawickramasingha warunawickramasingha self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Unit Tests for Engineering CalibrationInfo class
2 participants