Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change windows macro for warnings into compiler flags #38611

Open
wants to merge 2 commits into
base: release-next
Choose a base branch
from

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Jan 16, 2025

Reducing the contents of MantidKernel/System.h and the generated export headers should speed up mantid builds because the pre-compiler has less to parse. This migrates the 3 compiler waring suppressions to be compiler flags. It should have no effect on linux or osx which were already protected by the #ifdef macro.

Refs #38457

To test:

The builds passing is sufficient for this change to be considered correct. This is not user facing therefore does not require release notes.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Windows Only Only on Windows label Jan 16, 2025
@sf1919 sf1919 added this to the Release 6.12 milestone Jan 16, 2025
@jclarkeSTFC jclarkeSTFC changed the base branch from main to release-next January 16, 2025 15:39
@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Jan 16, 2025
@peterfpeterson peterfpeterson marked this pull request as ready for review January 16, 2025 21:30
@jclarkeSTFC jclarkeSTFC self-assigned this Jan 17, 2025
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine on Windows, if anyone using Visual Studio is reading this PR, then the disabled warnings end up here:

image

@thomashampson thomashampson self-assigned this Jan 17, 2025
@thomashampson
Copy link
Contributor

I'm going to wait until the end of today to merge this because I know that there are a couple of Windows developers finishing things off and it would be inconvenient if they had to rebuild right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Windows Only Only on Windows
Projects
Status: Review Approved
Development

Successfully merging this pull request may close these issues.

4 participants