-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output label option to ISIS Energy Transfer tab of Data Reduction #38607
base: main
Are you sure you want to change the base?
Conversation
a7a1734
to
47d69dd
Compare
Working on resolving the test failure |
47d69dd
to
83e28aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great solution to make sure workspaces are not overwritten and it is working well.
The only problem that I see is that using the OutputNameView
widget also displays the 'current output name' which suggests that an workspace with that name will be created. However, because the mehtod m_outputNamePresenter.setOutputWsBasename()
is never called, the name that the OutputName widget displays does not have a basename, eg. iris26176_graphite002
, so instead of displaying the expected iris26176_graphite002_some-label_red
, it's only showing _some-label
.
I think this is quite tricky to fix before code freeze, so what I think the simpler solution is is to just hide this part:
Since in OutputNameView.cpp
you have the example of enableLabelEditor()
I think you can write a similar function to disable the other text box?
If this proves to be too much, I am also happy to aprove as it is before code freeze, because ultimately I think the new functunality justifies it, and we can always improve it later in the nightly.
Yes, it should be hidden, how did you reproduce this? In my machine it is not shown. |
I am running on Linux, Ubuntu 20.04. I just built mantid as usual and opened the interface. |
Ok, I will check it thanks |
6a46c69
to
e0eb3d7
Compare
The release note structure for v6.13 has been created. You can now rebase your branch and move the release note in this PR. |
Description of work
This PR adds an output label option to the ISIS Energy Transfer tab in the Indirect Data Reduction interface. The output label will be appended to the output name and doesn't override previous outputs.
Summary of work
Fixes #38410.
To test:
1- Open Indirect Data Reduction interface
2- Go to ISIS Energy Transfer tab
3- Select IRIS, graphite 002
4- Load run 26176
5- Choose an output label
6- Click Run
7- The output label should be appended to the output name
8- Choose a different output label
9- Click Run
10- It should not override the previous data which was output in the ADS
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.