Capture c++ stack traces from core dump files on linux #38600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has to switch from multiprocessing to subprocess in order to do this (needed the preexec option). Through some testing, this should preserve the desired spawn behaviour. A new module 'workbench_process.py' has been created to use with subprocess.run (can't pass it a function)
jhaigh0
force-pushed
the
38405_capture_cpp_stacktraces_from_core_dumps
branch
from
e3ba601 to
8569ea0
Compare
jhaigh0
force-pushed
the
38405_capture_cpp_stacktraces_from_core_dumps
branch
from
8569ea0 to
b0238c0
Compare
jhaigh0
force-pushed
the
38405_capture_cpp_stacktraces_from_core_dumps
branch
from
b0238c0 to
83de376
Compare
|
The release note structure for v6.13 has been created. You can now rebase your branch and move the release note in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
pr under construction, running ci checks
Summary of work
Fixes #38405
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.