Surface Plotting from Multiple Single-Spectrum Workspaces #38599
Conversation
Despiix
added
the
ISIS Team: Core
There was a problem hiding this comment.
Looks good, just a couple of small things. Also, I think that the Contour option should have the Plot All option available, because you can type in a spectrum number and the OK button works, and the plot looks fine.
The other thing is that the linked issue also lists a problem with the wireframe plot, which hasn't been fixed.
| def check_num_spectra(self): | ||
| if not self._ui.specNums.text(): | ||
| if any(ws.getNumberHistograms() == 1 for ws in self._workspaces): | ||
| self._ui.specNums.setText("1") |
There was a problem hiding this comment.
Although the workspaces all have one spectrum, it doesn't necessarily mean that the spectrum numbers are all 1. You could call ws.getSpectrumNumbers()[0] to get the spectrum number for each workspace. Actually the spectrum numbers in the workspaces could all be different.
If the spectrum numbers are different in the different workspaces I think you may have to disable the spectrum box, since the Plot All and the workspace index box options are still available.
There was a problem hiding this comment.
I commited this fix as well, let me know if this is not what you meant.
There was a problem hiding this comment.
I also removed the "1". Now it sets the default value as the first valid spectrum number.
Set the default value as the first valid spectrum number
Description of work
Summary of work
Made it possible to plot a surface from a number of workspaces with 1 spectrum each, with one axis of the plot being a log value.Fixes #38171.
Report to:
@RichardWaiteSTFC @PascalManuel
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.