Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from MantidKernel/System.h to DllConfig.h #38543

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Dec 23, 2024

This is for PythonInterface, LiveData, and Nexus subpackages as part of #38457

To test:

This is a refactor to change #include and doesn't need more than the builds to pass.

This does not require release notes.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Dec 23, 2024
@peterfpeterson peterfpeterson force-pushed the 38457_more_places branch 2 times, most recently from dafc8df to 25f5cb3 Compare December 23, 2024 17:01
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Dec 27, 2024
Copy link

👋 Hi, @peterfpeterson,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This is for PythonInterface, LiveData, and Nexus subpackages as part
of mantidproject#38457
@peterfpeterson peterfpeterson removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Dec 27, 2024
@peterfpeterson peterfpeterson marked this pull request as ready for review December 27, 2024 20:41
@peterfpeterson peterfpeterson added this to the Release 6.12 milestone Dec 30, 2024
@robertapplin robertapplin self-assigned this Jan 2, 2025
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, and builds are passing

@thomashampson thomashampson self-assigned this Jan 2, 2025
@thomashampson thomashampson merged commit 9458f0a into mantidproject:main Jan 2, 2025
10 checks passed
@peterfpeterson peterfpeterson deleted the 38457_more_places branch January 3, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants