Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MantidKernel from System.h to DllConfig.h #38541

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Dec 20, 2024

This is part of #38457 which cleans up all of Kernel except the precompiled headers. System.h is still included in the generated DllConfig.h file, but all of its necessary functionality should have been pulled from System.h once everything else is ready.

Refs #38457

To test:

This is a simple refactor. The builds should all pass and this does not require release notes.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Dec 20, 2024
@peterfpeterson peterfpeterson added this to the Release 6.12 milestone Dec 20, 2024
@peterfpeterson peterfpeterson force-pushed the 38457_kernel_system_h branch 2 times, most recently from 0eae398 to 4114af6 Compare December 23, 2024 13:23
@peterfpeterson peterfpeterson marked this pull request as ready for review December 23, 2024 13:31
@peterfpeterson peterfpeterson force-pushed the 38457_kernel_system_h branch 5 times, most recently from 0bf3635 to d556861 Compare December 27, 2024 12:20
This is part of mantidproject#38457 which cleans up all of Kernel except the
precompiled headers. System.h is still included in the generated
DllConfig.h file, but all of its necessary functionality should have
been pulled from System.h once everything else is ready.
@peterfpeterson
Copy link
Member Author

This is being replaced with #38573.

@peterfpeterson peterfpeterson deleted the 38457_kernel_system_h branch January 7, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant