Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Framework/SINQ to generated DllConfig.h #38520

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Dec 17, 2024

As part of the effort to reduce compile time, change SINQ to use a generated DllConfig.h and remove MantidKernel/System.h from unit tests.

Refs #38457.

To test:

This is a simple refactor so the automated tests should continue to pass.

This does not require release notes because it is a refactor.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Dec 17, 2024
@peterfpeterson peterfpeterson changed the title Switch to generated DllConfig.h Switch Framework/SINQ to generated DllConfig.h Dec 17, 2024
@peterfpeterson peterfpeterson added this to the Release 6.12 milestone Dec 18, 2024
@peterfpeterson peterfpeterson marked this pull request as ready for review December 18, 2024 01:27
@cailafinn cailafinn merged commit 86ba0c5 into mantidproject:main Dec 19, 2024
10 checks passed
@peterfpeterson peterfpeterson deleted the 38457_sinq_system_h branch December 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants