-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
34850 systemtests with ctest #38381
base: main
Are you sure you want to change the base?
34850 systemtests with ctest #38381
Conversation
daa159d
to
0e6fc02
Compare
b6bd9ae
to
d10ed5f
Compare
4dba687
to
4a38114
Compare
4a38114
to
25e8a3c
Compare
Hi @cailafinn, Sarah told me yesterday in TWG about your PR. I think this is a great idea since the API of ctest is very complete. I try to reproduce the DrillProcessTest error on my machine, to no avail. |
I couldn't reproduce this locally either, on macOS or on Linux. So I'm not sure why it's failing on the build servers specifically yet |
We had something similar on our build server after a local change in our SANS algorithms. I pushed the fix we found at this moment for DrillProcessTest. This test does not fail anymore. Please tell me if I can help you anyhow. |
Description of work
Summary of work
Fixes #34850.
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.