Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34850 systemtests with ctest #38381

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

cailafinn
Copy link
Contributor

@cailafinn cailafinn commented Nov 11, 2024

Description of work

Summary of work

Fixes #34850.

Further detail of work

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn force-pushed the 34850_systemtests_with_ctest branch 4 times, most recently from daa159d to 0e6fc02 Compare November 12, 2024 17:37
@cailafinn cailafinn closed this Nov 13, 2024
@cailafinn cailafinn reopened this Nov 13, 2024
@cailafinn cailafinn force-pushed the 34850_systemtests_with_ctest branch from b6bd9ae to d10ed5f Compare November 13, 2024 15:41
@cailafinn cailafinn force-pushed the 34850_systemtests_with_ctest branch from 4dba687 to 4a38114 Compare November 25, 2024 17:05
@cailafinn cailafinn force-pushed the 34850_systemtests_with_ctest branch from 4a38114 to 25e8a3c Compare November 25, 2024 17:06
@perenon
Copy link
Contributor

perenon commented Dec 18, 2024

Hi @cailafinn, Sarah told me yesterday in TWG about your PR. I think this is a great idea since the API of ctest is very complete.

I try to reproduce the DrillProcessTest error on my machine, to no avail.
The strange part is that the test report says "status: success", with a SegFault at the end. Could you reproduce it locally ?

@cailafinn
Copy link
Contributor Author

I try to reproduce the DrillProcessTest error on my machine, to no avail. The strange part is that the test report says "status: success", with a SegFault at the end. Could you reproduce it locally ?

I couldn't reproduce this locally either, on macOS or on Linux. So I'm not sure why it's failing on the build servers specifically yet

@perenon
Copy link
Contributor

perenon commented Dec 31, 2024

We had something similar on our build server after a local change in our SANS algorithms.
The tests hung indefinitely on the build server and, locally, DrillProcessTest provided a SegFault.

I pushed the fix we found at this moment for DrillProcessTest. This test does not fail anymore. Please tell me if I can help you anyhow.

@cailafinn cailafinn added this to the Release 6.13 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate using ctest to run system tests
3 participants