AlignAndFocusPowderSlim prototype #38279
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't re-run tests on this on as it genuinely fails |
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
540c68d to
4394803
Compare
rosswhitfield
force-pushed
the
ewm6343_aafpff_slim
branch
from
4394803 to
d523b88
Compare
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
2 times, most recently
from
4e13c5c to
57a16ad
Compare
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
2 times, most recently
from
dec7fda to
eef6346
Compare
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
2 times, most recently
from
c94d1da to
8b01ea8
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
8b01ea8 to
4b1db75
Compare
peterfpeterson
removed
the
Has Conflicts
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
4b1db75 to
9a08782
Compare
github-actions
bot
removed
the
Has Conflicts
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
9a08782 to
93a2eb1
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
2 times, most recently
from
824cd74 to
1613e00
Compare
peterfpeterson
removed
the
Has Conflicts
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
1613e00 to
403a1ac
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
403a1ac to
c6bc28b
Compare
peterfpeterson
removed
the
Has Conflicts
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
2 times, most recently
from
55ea2d1 to
2801046
Compare
for more information, see https://pre-commit.ci
This is a squashed version of mantidproject#38564 Clear events in frame if not good frame In preparation for next frame Update cpp check suppression The condition ++numWordsSkipped is always true, but it will only get evaluated if !file.seekg(SKIP_WORD_SIZE, std::ios_base::cur).eof() is true which will indicate a word being skipped, so this does actually have a function! Update test to assert no events if min=max=0 Add release note Fix cpp check supression
This is a squashed version of mantidproject#38459 fix typo to trigger cppcheck run Remove cppcheck suppressions temporarily for cppcheck update Update cppcheck to 2.16.0 Suppress class_X_Y cppcheck warnings. Restrict cppcheck to unix only. There is no 2.16.0 for Windows. We can re-add it for Windows in the future if it is reinstated. For the time being, since nobody is running it locally, we don't really need it to be installed on Windows. Sort cppcheck supressions by file name and line number Group internal cppcheck errors to extract them from the bounty list Update cppcheck suppressions for v2.16.0
for more information, see https://pre-commit.ci
…_16_ornlnext Update cppcheck to 2.16.0 - ornlnext
for more information, see https://pre-commit.ci
peterfpeterson
force-pushed
the
ewm6343_aafpff_slim
branch
from
d1c9962 to
587b566
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still has #38455 in it. Once that is merged this will be significantly smaller.
Description of work
Summary of work
Fixes #xxxx.
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.