-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rawdata explorer widget #34691
base: main
Are you sure you want to change the base?
Rawdata explorer widget #34691
Conversation
e796771
to
05bb78e
Compare
👋 Hi, @MathieuTillet, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
In the rdexp widget, add the file management and a very rudimentary display mecanism.
This is a simple tag that indicates if an instrument is 1D or 2D.
Only for some ILL instruments for which all the info are already here.
In the raw data explorer, most of the display types are now supported. Slice Viewer and Instrument view needs polishing to manage their behaviour when closing.
The view sends a signal when it is closed through the close button. This signals is caught by the presenter to remove the instrument viewer from the manager.
This pull request has been automatically marked as stale because it has not had activity in 3 months. It will be closed in 7 days if no further activity occurs. |
Up |
This pull request has been automatically marked as stale because it has not had activity in 3 months. It will be closed in 7 days if no further activity occurs. |
(Re-)Up |
👋 Hi, @MathieuTillet, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
This pull request has been automatically marked as stale because it has not had activity in 3 months. It will be closed in 7 days if no further activity occurs. |
(Yet another) up |
Description of work.
This PR introduces the Raw Data Explorer widget, designed to browse raw data files in a streamlined way.
The widget appears tiled under the workspace list, and allow the user to select a directory and browse starting from there. Every time they click on a file, it is loaded and displayed in what is supposed to be the most appropriate way. Only one preview can exist at a time, so unused ones are closed as soon as they are not necessary.
By holding the control key, the user can accumulate different files, effectively summing them. Un-accumulating is not supported.
When the total memory used goes over 80% by Mantid count, unused workspaces are deleted until the memory goes down to a more reasonable value, starting by the ones that have not been interacted with for the longest time.
Testing this widget mainly consists in using it. It is supposed to support all the raw data that Mantid can load, or handle gracefully errors. In particular, since it has been developed exclusively on Ubuntu, checking that Qt behaves on other system would be good.
Attached RDExp.pdf is the requirement document, which might be useful for reference of expected behaviors and features.
To test:
Workspaces
widget.InstrumentView
, while other instruments from outside ILL would be visualized in theInstrumentView
widget at the moment.Ctrl
key. Displayed data should be added in the visualization.Fixes #29249 .
Release note and documentation added.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.