Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Unit Tests for Engineering CalibrationInfo class #38888

Open
andy-bridger opened this issue Feb 19, 2025 · 0 comments · May be fixed by #38894
Open

No Unit Tests for Engineering CalibrationInfo class #38888

andy-bridger opened this issue Feb 19, 2025 · 0 comments · May be fixed by #38894
Labels
Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 6.13

Comments

@andy-bridger
Copy link
Collaborator

Describe the outcome that is desired.
Currently there are no unit tests for the CalibrationInfo class in Engineering/common/calibration_info.py. It looks like initially it was just a container with getter and setter methods for holding, as the name suggest, calibration information, but as of now there is a fair amount of logic present surrounding what detector grouping is used.

It would be preferable to test these functions on their own, rather than when they are called through the interface

Describe any solutions you are considering
Add Unit tests that directly test the CalibrationInfo class
@andy-bridger andy-bridger added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Feb 19, 2025
@andy-bridger andy-bridger added this to the Release 6.13 milestone Feb 19, 2025
@andy-bridger andy-bridger self-assigned this Feb 19, 2025
@andy-bridger andy-bridger added Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS labels Feb 19, 2025
@andy-bridger andy-bridger linked a pull request Feb 19, 2025 that will close this issue
Open
@andy-bridger andy-bridger moved this from Icebox to Ready for Review in Mantid Maintenance Feb 20, 2025
@andy-bridger andy-bridger removed their assignment Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Mantid Maintenance
Status: Ready for Review
Milestone
Release 6.13
Development

Successfully merging a pull request may close this issue.

Add testing for CalibrationInfo mantidproject/mantid
1 participant
@andy-bridger