fix(useSelections): setSelected should support non-array value (ali…

…baba#2559) * fix(useSelections): `setSelected` should support `undefined` * test: add case for `null`
mannix-lei · Jun 2, 2024 · a75a982 · a75a982
1 parent ccf14eb
commit a75a982
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/hooks/src/useSelections/__tests__/index.test.ts b/packages/hooks/src/useSelections/__tests__/index.test.ts
@@ -183,6 +183,12 @@ describe('useSelections', () => {
       expect(result.current.noneSelected).toBe(false);
       expect(result.current.allSelected).toBe(true);
       expect(result.current.partiallySelected).toBe(false);
+
+      // Keep compatible with older versions.
+      act(() => {
+        expect(() => setSelected(undefined!)).not.toThrowError();
+        expect(() => setSelected(null!)).not.toThrowError();
+      });
     };
 
     runCaseCallback(caseCallback, caseCallback);

diff --git a/packages/hooks/src/useSelections/index.ts b/packages/hooks/src/useSelections/index.ts
@@ -36,6 +36,10 @@ export default function useSelections<T>(items: T[], options?: T[] | Options<T>)
   const selectedMap = useMemo(() => {
     const keyToItemMap = new Map();
 
+    if (!Array.isArray(selected)) {
+      return keyToItemMap;
+    }
+
     selected.forEach((item) => {
       keyToItemMap.set(getKey(item), item);
     });