chore: upgrade core-js to v3

mannix-lei · Nov 10, 2021 · a68592d · a68592d
1 parent ec49be2
commit a68592d
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 17 deletions.
diff --git a/.babelrc b/.babelrc
@@ -6,7 +6,8 @@
         "loose": true,
         "modules": false,
         "targets": "> 0.25%, not dead",
-        "useBuiltIns": "usage"
+        "useBuiltIns": "usage",
+        "corejs": 3
       }
     ],
     "@babel/react"

diff --git a/packages/hooks/package.json b/packages/hooks/package.json
@@ -33,7 +33,7 @@
   ],
   "dependencies": {
     "@ahooksjs/use-request": "^3.0.0-alpha.0",
-    "core-js": "^2.6.12",
+    "core-js": "^3.19.1",
     "dayjs": "^1.9.1",
     "intersection-observer": "^0.7.0",
     "js-cookie": "^2.2.1",

diff --git a/packages/hooks/src/utils/depsAreSame.ts b/packages/hooks/src/utils/depsAreSame.ts
@@ -1,19 +1,5 @@
 import type { DependencyList } from 'react';
 
-if (!Object.is) {
-  Object.is = function (x, y) {
-    // SameValue algorithm
-    if (x === y) {
-      // Steps 1-5, 7-10
-      // Steps 6.b-6.e: +0 != -0
-      return x !== 0 || 1 / x === 1 / y;
-    } else {
-      // Step 6.a: NaN == NaN
-      return x !== x && y !== y;
-    }
-  };
-}
-
 export default function depsAreSame(oldDeps: DependencyList, deps: DependencyList): boolean {
   if (oldDeps === deps) return true;
   for (let i = 0; i < oldDeps.length; i++) {

diff --git a/packages/use-url-state/package.json b/packages/use-url-state/package.json
@@ -33,7 +33,7 @@
   },
   "dependencies": {
     "ahooks": "^3.0.0-alpha.2",
-    "core-js": "^2.6.12",
+    "core-js": "^3.19.1",
     "query-string": "^6.9.0"
   }
 }
diff --git a/umd.html b/umd.html
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="UTF-8" />
+    <title>Hello World</title>
+    <script src="https://unpkg.com/react@17/umd/react.development.js"></script>
+    <script src="https://unpkg.com/react-dom@17/umd/react-dom.development.js"></script>
+
+    <!-- Don't use this in production: -->
+    <script src="https://unpkg.com/@babel/standalone/babel.min.js"></script>
+  </head>
+  <body>
+    <div id="root"></div>
+    <script src="./packages/hooks/dist/ahooks.js"></script>
+
+    <script type="text/babel">
+      const { useToggle } = window.ahooks;
+      const Demo = () => {
+        const [show, { toggle }] = useToggle(false);
+        return (
+          <div>
+            <button onClick={toggle}>Toggle</button>
+            {show && <div>Hello World</div>}
+          </div>
+        );
+      };
+      ReactDOM.render(<Demo />, document.getElementById('root'));
+    </script>
+  </body>
+</html>