Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor python script/gradle and (hopefully) add Mac M1 support #48

Closed
wants to merge 1 commit into from

Conversation

rchtsang
Copy link

@rchtsang rchtsang commented Jun 12, 2023

automates the build process outlined in #34 (comment) without the virtual environment part (uses default python as before).

renamed and changed python script util to support pre and post scripting (needed for renaming binaries after building dist). likewise changed build.gradle to support pre and post scripts. also added os/mac_arm_64 folder.

postscript also has option for automatic installation to Ghidra/Extensions folder though this is neither enabled nor tested.

seems to be working on mac m1 pro 13.3.1 with Ghidra 10.3, but untested on other platforms and should probably be tested by other m1 users.

…ing. likewise changed build.gradle to support pre and post scripts. also added os folder for mac_arm_64. working on m1, but untested on other platforms
@williballenthin
Copy link
Contributor

i have an M1 mac mini and can try this out shortly, ideally in the next few days.

@williballenthin williballenthin added the macos Issue related to MacOS label Jun 12, 2023
@rchtsang
Copy link
Author

so i know that #50 would supersede this (and for reasons I agree with) but would the modified python/gradle script still be useful?

if not then this pr can be closed altogether i think.

@mike-hunhoff
Copy link
Collaborator

Thank you for your contribution - this has been superseded by 32f3969.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issue related to MacOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants